gtk_text_buffer_create_tag(): returns NULL on failure

Returns NULL in case of a duplicated tag name in the tag table. It is
still a programmer error to duplicate a name, but if it happens the
behavior is a little nicer (and hopefully doesn't crash).

https://bugzilla.gnome.org/show_bug.cgi?id=614717

diff --git a/gtk/gtktextbuffer.c b/gtk/gtktextbuffer.c
index e562c331ec14304c78ae64b9d3e27718278cd0df..6a03b55f2a3367143a569bc4539327b5fc4568d1 100644 (file)
--- a/gtk/gtktextbuffer.c
+++ b/gtk/gtktextbuffer.c
@@ -2493,7 +2493,11 @@ gtk_text_buffer_create_tag (GtkTextBuffer *buffer,
 
   tag = gtk_text_tag_new (tag_name);
 
-  gtk_text_tag_table_add (get_table (buffer), tag);
+  if (!gtk_text_tag_table_add (get_table (buffer), tag))
+    {
+      g_object_unref (tag);
+      return NULL;
+    }
 
   if (first_property_name)
     {